GitHub Issue #696: Make Applying Filters to Custom Grid View More Apparent - #7987
Open
cnathe wants to merge 2 commits into
Open
GitHub Issue #696: Make Applying Filters to Custom Grid View More Apparent#7987cnathe wants to merge 2 commits into
cnathe wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/696
App grid filter updates to makes it obvious that saving a grid view includes the current set of filters and sorts. Read-only (saved-with-view) filter pills in the grid message bar are greyed and get a hover popover explaining why they can't be edited. The Save Grid View modal replaces the easy-to-miss "Columns, sort order, and filters will be saved" sentence with two labelled sections listing the actual filter and sort pills that will be persisted, with empty-state messages when there are none.
Related Pull Requests
Changes